Remove unused variables #247
Conversation
Source/GSHorizontalTypesetter.m
Outdated
| }*/ | ||
|
|
||
| last_p = g->pos = p; |
There was a problem hiding this comment.
I am not sure whether the setting of g->pos that got removed here is really not needed. If so, could you please explain why?
There was a problem hiding this comment.
You are right, this was too greedy on my side.
|
I am fine with removing the unused variable from the second file.. In the first file things are different. Actually it would be great if we did use this variable and if the commented out code would be active. So instead of removing this variable we should try to get this code faster and reenable it again. |
Fixes a compiler warnings
qmfrederik
force-pushed
the
warnings-unused-variable
branch
from
3c9792a to
b3038e3
Compare
|
@fredkiefer Thanks for reviewing this. I reduced the scope of this patch to focus on the first file only. You are probably right and the proper fix is to re-enable the commented out code, but that's a bit beyond the mindset of "let's see if there's low hanging fruit to reduce compiler warnings" I had when I opened these PRs. |
Suppresses a couple of build warnings (-Wunused-but-set-variable)