-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove active account usage #130
Conversation
Be careful in this use of |
In dsocial/mobile, I enter
|
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
ea939b8
to
4dc9db7
Compare
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android and iOS simulators.
Similar to PR gnoverse/dsocial#130, we update gnoboard to use the new Gno Native Kit API which removes `selectAccount` and requires passing the account address to `setPassword`, etc. This PR has five commits: 1. The app needs to keep track of the active account, so add `GnoboardProvider`. 2. Instead of calling Gno Native Kit `selectAccount`, call `GnoboardProvider` `setAccount` to remember the active account. 3. `setPassword` needs the account address, so in `ReenterPassword` add param `accountAddress`. 4. In wallet/home: Pass in the account instead of calling `getActiveAccount`. Use the account address to call `queryAccount`. 5. As in a [similar dsocial PR](gnoverse/dsocial#134), fix the Makefile to call ts_check after node_modules. With this PR, all known apps have been updated to remove `selectAcount` and to pass the account address to the methods of Gno Native Kit, which can be updated to remove deprecated functions and to make the address not optional. --------- Signed-off-by: Jeff Thompson <jeff@thefirst.org>
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.