Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary functions from the gns realm #482

Merged
merged 4 commits into from
Jan 24, 2025
Merged

refactor: remove unnecessary functions from the gns realm #482

merged 4 commits into from
Jan 24, 2025

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jan 21, 2025 •
edited
Loading

Description

  1. Remove unnecessary function in gns

related manfred comment #465 (comment)

  1. use Token object if possible

since Token is read-only object, it is safer

@r3v4s r3v4s changed the title refactor: remove unnecessary function from gns WIP // refactor: remove unnecessary function from gns Jan 21, 2025
@r3v4s r3v4s force-pushed the remove-unnecessary-func-in-gns branch from fd19fbb to 63d7876 Compare January 22, 2025 09:57
@dongwon8247 dongwon8247 changed the title WIP // refactor: remove unnecessary function from gns refactor(wip): remove unnecessary functions from the gns realm Jan 22, 2025
@r3v4s r3v4s force-pushed the remove-unnecessary-func-in-gns branch from 63d7876 to b14b12e Compare January 22, 2025 10:10
@r3v4s r3v4s changed the title refactor(wip): remove unnecessary functions from the gns realm refactor: remove unnecessary functions from the gns realm Jan 22, 2025
@r3v4s r3v4s self-assigned this Jan 22, 2025
@r3v4s r3v4s marked this pull request as ready for review January 22, 2025 10:14
dongwon8247
dongwon8247 previously approved these changes Jan 22, 2025
View reviewed changes
@r3v4s r3v4s requested a review from dongwon8247 January 22, 2025 10:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s mentioned this pull request Jan 23, 2025
Draft
onlyhyde
onlyhyde approved these changes Jan 23, 2025
View reviewed changes
contract/r/gnoswap/gns/gns.gno Show resolved Hide resolved
@dongwon8247 dongwon8247 merged commit 80ccca4 into main Jan 24, 2025
2 checks passed
@dongwon8247 dongwon8247 deleted the remove-unnecessary-func-in-gns branch January 24, 2025 00:25
moul pushed a commit that referenced this pull request Jan 24, 2025
@r3v4s @moul
refactor: remove unnecessary functions from the gns realm (#482)
4f4dd5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon Awaiting requested review from notJoon

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @onlyhyde @dongwon8247