Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: msgEval support #464

Closed
wants to merge 2 commits into from
Closed

Conversation

ltzmaxwell
Copy link
Contributor

Description

support msgEval protocol , can evaluate an GNO expression from query and msgEval as well.

How has this been tested?

tests passed.

@ltzmaxwell ltzmaxwell requested a review from a team as a code owner January 19, 2023 07:17
@moul moul mentioned this pull request Jan 19, 2023
@moul
Copy link
Member

moul commented Jan 19, 2023

Related with #444

@piux2
Copy link
Contributor

piux2 commented Jan 23, 2023

Thank you for your contribution.

What problem are we trying to solve? What is the difference between msgEval and MsgCall?

Here is the path of changes msgEval -> msgExec -> msgCall in Oct and Nov 2021

@jaekwon
Copy link
Contributor

jaekwon commented Jan 25, 2023

What is the concise and complete description of what it does?
It's a tx meant to be included in the chain.
Does it evaluate any expression (including 1+1?) and return the result in ABCI? Does it have any side effects or are any state changes discarded?

@ltzmaxwell ltzmaxwell closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants