-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: document that imaginary numbers are not supported, in go-gno-compatibility.md #3852
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@@ -61,6 +61,7 @@ rune := rune('a') | |||
| `func (T1...) T2...` | full | full (needs more tests) | | |||
| `*T` (pointers) | full | full\* | | |||
| `chan T` (channels) | missing (after launch) | missing (after launch) | | |||
| `imag` | unsupported | unsupported | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the imag
type doesn't actually exist, the types are complex64
and complex128
which are stated above to not be supported. We talk about "imag" indirectly with the reference for builtin
:
builtin is a "fake" package that exists to document the behaviour of some builtin functions. The "fake" package does not currently exist in Gno, but all functions up to Go 1.17 exist, except for those relating to complex or channel types.
For searchability, you can add real
and imag
in that footnote.
…nsupported Imaginary values are not supported in Gno. Found by fuzzing and compatibility checks between Go and Gno ```go package main const ( Nj = 0i ) ```
Thank you for the review @thehowl. Kudos for the good knowledge of the doc's content. |
Imaginary values are not supported in Gno. Found by fuzzing and compatibility checks between Go and Gno