Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnoweb): add secure headers by default & timeout configuration #3619
base: master
Are you sure you want to change the base?
feat(gnoweb): add secure headers by default & timeout configuration #3619
Changes from 3 commits
e1861e7
e5fe991
84ebdba
432d889
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 142 in gno.land/cmd/gnoweb/main.go
Codecov / codecov/patch
gno.land/cmd/gnoweb/main.go#L136-L142
Check warning on line 155 in gno.land/cmd/gnoweb/main.go
Codecov / codecov/patch
gno.land/cmd/gnoweb/main.go#L149-L155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I haven't tested it locally yet, but is there a way to host images (for example) on Gnoweb? Because if we restrict access to "img-src" to "self" and there are no tricks for hosting them on Gnoweb, it will force user to hardcode base64 in their markdown.
And I have a feeling that hardcoding binary data into source code is not a great idea. We might need an equivalent to git-lfs. Or a way to host photos on the gno.land domain that relies on simple object storage and is not tied to the blockchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a really good point. Discussing a bit with @moul, the plan is to have a whitelist of authorized hosts for images. We can keep allowing any external source for now (for images only) until we implement this whitelist system. I think we also want to deny any embed
data:
to prevent people from storing raw images on gnoland, but I'm unsure of applying this in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got it. Looks good 👍
Check warning on line 250 in gno.land/cmd/gnoweb/main.go
Codecov / codecov/patch
gno.land/cmd/gnoweb/main.go#L224-L250
Check warning on line 252 in gno.land/cmd/gnoweb/main.go
Codecov / codecov/patch
gno.land/cmd/gnoweb/main.go#L252