Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gno mod graph #3588

Merged
merged 13 commits into from
Jan 29, 2025
Merged

feat: gno mod graph #3588

merged 13 commits into from
Jan 29, 2025

Conversation

moul
Copy link
Member

@moul moul commented Jan 23, 2025

Basic initial version compatible with go mod graph in terms of output, while allowing the specification of folders through an optional argument.

  • implement
  • tests
  • share examples

Depends on #3587

moul added 4 commits January 23, 2025 09:15
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Jan 23, 2025
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Jan 23, 2025
@Gno2D2 Gno2D2 requested review from a team January 23, 2025 09:16
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 23, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/mod.go 83.78% 4 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

moul added 2 commits January 23, 2025 11:06
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul added 2 commits January 23, 2025 12:52
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Copy link
Member Author

moul commented Jan 24, 2025

gno mod graph ./examples | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph.svg

graph


gno mod graph ./examples | grep -v /r/ | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph2.svg

graph2


gno mod graph ./examples | grep -v /p/ | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph3.svg

graph3


gno mod graph ./examples | grep /moul/ | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph4.svg

graph5


gno mod graph ./examples | grep /sys/ | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph5.svg

graph6


gno mod graph ./examples | grep /gov/ | go run golang.org/x/exp/cmd/modgraphviz@latest | dot -Tsvg -o graph6.svg

graph4

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review January 24, 2025 17:15
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 24, 2025
@moul moul changed the title WIP feat: gno mod graph feat: gno mod graph Jan 24, 2025
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@zivkovicmilos zivkovicmilos self-requested a review January 26, 2025 18:56
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

I think a master pull into this branch will resolve the CI issues-- but I can't seem to do it on my own

@moul moul merged commit b392287 into gnolang:master Jan 29, 2025
57 checks passed
@moul moul deleted the dev/moul/mod-graph branch January 29, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants