-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(examples): use std.Address based behaviour #3580
refactor(examples): use std.Address based behaviour #3580
Conversation
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
0f47749
to
b2bfbc0
Compare
Just a heads up: I also made this change in #3166 - you'll want to check out the API of |
@r3v4s can you check the bot which is making the CI red? And we can merge after |
Please enable the "Allow edits from maintainers" option to fix CI fail. |
There was a request to open PRs from our personal forks to address this, not sure you can/should enable this at your org level |
Clicked "ignore" on the bot because the last requirement seems to be a bug on github. Pr looks good. |
Changes were only in the examples folder, but CI didn't run txtar tests on this change breaking master. Fixing: #3590 |
## Description To make contracts more simpler(and low computation for execution), it is better for contract to manipulate with only `std.Address` rather than using `users.AddressOrName` and resolving it. ([Discussed with @moul](gnoswap-labs/gnoswap#465 (comment))) Clients such as gnoeky, gnoweb or adena should perform look up(convert username to address) and pass address value to contract.
## Description Fixes txtar that needed to be in gnolang#3580 Should've been caught by CI, wasn't --------- Co-authored-by: Morgan Bazalgette <morgan@morganbaz.com>
Description
To make contracts more simpler(and low computation for execution), it is better for contract to manipulate with only
std.Address
rather than usingusers.AddressOrName
and resolving it. (Discussed with @moul)Clients such as gnoeky, gnoweb or adena should perform look up(convert username to address) and pass address value to contract.