Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tm2/pkg/iavl): add FuzzIterateRange and modernize FuzzMutableTree #3548

Merged

Conversation

odeke-em
Copy link
Contributor

This change hooks MutableTree fuzzing to Go's native fuzzing that's more intelligent and coverage guided to mutate inputs instead of naive random program generation.
While here also added FuzzIterateRange.

Updates #3087

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 19, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 19, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @thehowl)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: odeke-em/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@odeke-em odeke-em force-pushed the iavl-convert-fuzzer-to-Go-native-fuzzer branch 4 times, most recently from 5d8bb6e to 9b58e6f Compare January 19, 2025 06:23
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
@jefft0
Copy link
Contributor

jefft0 commented Jan 22, 2025

Hello @odeke-em . Can you fix the Go Lint error?

@odeke-em odeke-em force-pushed the iavl-convert-fuzzer-to-Go-native-fuzzer branch 2 times, most recently from 763b93b to 0e66581 Compare January 22, 2025 15:42
@odeke-em
Copy link
Contributor Author

Done and thanks for the ping @jefft0, please take a look.

Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remove review/triag-pending flag.

@notJoon notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 23, 2025
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

tm2/pkg/iavl/tree_fuzz_test.go Outdated Show resolved Hide resolved
tm2/pkg/iavl/tree_fuzz_test.go Outdated Show resolved Hide resolved
tm2/pkg/iavl/tree_fuzz_test.go Outdated Show resolved Hide resolved
@odeke-em odeke-em force-pushed the iavl-convert-fuzzer-to-Go-native-fuzzer branch from 957b09b to a21750e Compare January 24, 2025 02:34
@Gno2D2 Gno2D2 requested a review from a team January 24, 2025 02:35
@odeke-em odeke-em force-pushed the iavl-convert-fuzzer-to-Go-native-fuzzer branch from a21750e to 0a2f208 Compare January 24, 2025 07:05
This change hooks MutableTree fuzzing to Go's native fuzzing that's
more intelligent and coverage guided to mutate inputs instead of
naive random program generation.
While here also added FuzzIterateRange.

Updates gnolang#3087
@odeke-em odeke-em force-pushed the iavl-convert-fuzzer-to-Go-native-fuzzer branch from 0a2f208 to 44beba0 Compare January 31, 2025 20:11
@n2p5 n2p5 merged commit 7992a29 into gnolang:master Jan 31, 2025
60 checks passed
@odeke-em odeke-em deleted the iavl-convert-fuzzer-to-Go-native-fuzzer branch January 31, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Development

Successfully merging this pull request may close these issues.

6 participants