Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs/std)!: remove Get prefixes, extend abbreviations #3374

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

hthieu1110
Copy link
Contributor

@hthieu1110 hthieu1110 commented Dec 19, 2024

Linked to #1475

  • GetCallerAt =>CallerAt
  • GetOrigSend => OriginSend
  • origSend => originSend
  • GetOrigCaller => OriginCaller
  • origCaller => originCaller
  • Orig => Origin
  • Addr => Address
  • PrevRealm => PreviousRealm
  • GetChainID => ChainID
  • GetBanker => NewBanker
  • GetChainDomain => ChainDomain
  • GetHeight => Height

BREAKING CHANGE: changes many of the existing standard library functions.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 19, 2024
@Gno2D2 Gno2D2 requested review from a team December 19, 2024 14:31
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

🔴 Must not contain the "don't merge" label

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff
🔴 Must not contain the "don't merge" label
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: hthieu1110/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/assets/how-to-guides/creating-grc20/mytoken-1.gno)

Then

🟢 Requirement satisfied
└── 🟢 And
    ├── 🟢 Or
    │   ├── 🔴 Pull request author is a member of the team: tech-staff
    │   └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🟢 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🟢 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 83.83838% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/tests/stdlibs/std/std.go 40.00% 6 Missing ⚠️
gnovm/stdlibs/std/banker.go 0.00% 5 Missing ⚠️
gnovm/stdlibs/std/native.go 72.22% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hthieu1110 hthieu1110 marked this pull request as ready for review December 19, 2024 16:01
@hthieu1110 hthieu1110 changed the title feat(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller Dec 20, 2024
@hthieu1110 hthieu1110 changed the title refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller and extend abbreviations Dec 20, 2024
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 20, 2024
docs/reference/stdlibs/std/realm.md Show resolved Hide resolved
docs/reference/stdlibs/std/chain.md Outdated Show resolved Hide resolved
docs/reference/stdlibs/std/testing.md Outdated Show resolved Hide resolved
examples/gno.land/p/demo/grc/grc20/examples_test.gno Outdated Show resolved Hide resolved
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 20, 2024
@Kouteki Kouteki requested review from petar-dambovaliev and mvertes and removed request for a team December 20, 2024 12:07
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Dec 20, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 17, 2025
@thehowl
Copy link
Member

thehowl commented Jan 20, 2025

CI is failing :(

@Gno2D2 Gno2D2 requested a review from a team January 20, 2025 08:47
@hthieu1110
Copy link
Contributor Author

CI is failing :(

Oh, my bad. CI has been fixed and test5 genesis has been reverted. @thehowl

@thehowl thehowl changed the title refactor(stdlibs)!: remove Get prefixes, extend abbreviations feat(stdlibs)!: remove Get prefixes, extend abbreviations Jan 21, 2025
@thehowl thehowl changed the title feat(stdlibs)!: remove Get prefixes, extend abbreviations feat(stdlibs/std)!: remove Get prefixes, extend abbreviations Jan 21, 2025
@Gno2D2 Gno2D2 requested a review from a team January 21, 2025 12:38
@Kouteki Kouteki removed request for petar-dambovaliev and a team January 22, 2025 14:16
@Gno2D2 Gno2D2 requested a review from a team January 27, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes don't merge Please don't merge this functionality temporarily in focus Core team is prioritizing this work 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

9 participants