-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: r/demo/users
#3166
base: master
Are you sure you want to change the base?
refactor: r/demo/users
#3166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
# Conflicts: # examples/gno.land/r/demo/users/users.gno # examples/gno.land/r/demo/users/z_10_filetest.gno # examples/gno.land/r/demo/users/z_11_filetest.gno # examples/gno.land/r/demo/users/z_11b_filetest.gno # examples/gno.land/r/demo/users/z_2_filetest.gno # examples/gno.land/r/demo/users/z_3_filetest.gno # examples/gno.land/r/demo/users/z_4_filetest.gno # examples/gno.land/r/demo/users/z_5_filetest.gno # examples/gno.land/r/demo/users/z_6_filetest.gno # examples/gno.land/r/demo/users/z_7_filetest.gno # examples/gno.land/r/demo/users/z_7b_filetest.gno # examples/gno.land/r/demo/users/z_8_filetest.gno # examples/gno.land/r/demo/users/z_9_filetest.gno # examples/gno.land/r/sys/users/verify.gno
Would you like to provide any preliminary feedback on the API before I go on renaming everything in the examples folder? P.S. sorry about the force push, I messed something up with git. |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
# Conflicts: # examples/gno.land/r/demo/users/z_5_filetest.gno
Added FIFO to the rendering of Also, let's see how we're going to patch the Portal Loop for this 🙏 |
Description
Addresses: #2827
This PR refactors the current
r/demo/users
&r/sys/users
system in accordance to the issue mentioned above. Below is the high-level overview of the new system.It also makes a small change to the
p/demo/releases
lib.r/gnoland/users/v1
r/demo/users
r/sys/users
Mainnet v1 (mvp) & v2 #2827r/demo/profile
for displaying extra information about a user (to be moved tor/nt/profiles
orr/gnoland/profiles
)r/sys/users
r/sys/names
r/gnoland/users/v1
, etc.r/gov/dao/bridge
#3523 was resolved)r/sys/names
r/sys/users
), added tests, as discussed with @moulVerify functionality is now not pausable and on by default, as per discussions with @moul. This means Portal Loop will need to be patched upon merging this PR, as many txs will fail due to not having proper namespace permissions.The namespace verify functionality is off by default, but should be enabled in genesis viar/sys/names.Enable()
. The Portal Loop will indeed need to be patched if we enable this functionality.Keeper
& genesis paramsr/sys/names
for the namespace check instead ofr/sys/users
r/sys/names
, which the keeper will callr/gnoland/users/v1
r/gnoland/users
Currently this is the "releases" page for the user registration systems (example data):
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description