Allow numbers in custom objects system names #18802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
11.0/allow-numbers-in-custom-assets
branch
from
ea302ac to
59a8c8a
Compare
|
Yes, it could be useful |
|
Yes, no problem |
cedric-anne
force-pushed
the
11.0/allow-numbers-in-custom-assets
branch
from
59a8c8a to
47d641b
Compare
cedric-anne
force-pushed
the
11.0/allow-numbers-in-custom-assets
branch
from
47d641b to
24f6935
Compare
trasher
approved these changes
Jan 30, 2025
orthagh
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
People may want to use numbers in custom assets system names. Prior to GLPI 9.4, it was possible to use classnames with numbers in the search engine, for instance via the genericobject plugin. This possibility disappeared when the search engine was refactored, and we did not reverted this limitation because the issue was detected only after the GLPI 9.4.0 release (see #5495).
I think we could reintroduce the possibility to use numbers in itemtypes. The search engine has many test and some of them will probably fail if an unexpected side effect is introduced by this change.