Fixes date fields autofilling on edit #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 64.83% 58.56% -6.27%
==========================================
Files 150 114 -36
Lines 4874 3596 -1278
Branches 1505 1177 -328
==========================================
- Hits 3160 2106 -1054
+ Misses 1714 1490 -224 ☔ View full report in Codecov by Sentry. |
jim-sheldon
force-pushed
the
dont-autofill-event-dates
branch
from
575ee8b to
3004280
Compare
| @@ -193,6 +193,8 @@ interface DateFieldProps { | |||
| export function DateField(props: DateFieldProps): JSX.Element { | |||
| const classes = useStyles(); | |||
|
|
|||
| const dateValue = props.value || 'yyyy/MM/dd'; | |||
There was a problem hiding this comment.
'yyyy/MM/dd' seems to be a format not a value, am I missing something?
stanislaw-zakrzewski
approved these changes
Mar 26, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.