Showing curator info on edit page #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-sheldon
force-pushed
the
curation-info
branch
from
0e822d4 to
b61be1b
Compare
jim-sheldon
force-pushed
the
curation-info
branch
from
b61be1b to
52f1a51
Compare
Changes: * Remove dependency between curator and age range in case model * Update minimal case and full case to work with curator model chagnes
| @@ -88,40 +98,43 @@ const dtoFromCase = async (storedCase: CaseDocument) => { | |||
| }); | |||
| } | |||
|
|
|||
| if (ageRange && creator) { | |||
There was a problem hiding this comment.
This was the main culprit causing issues with tests. this if SHOULD only contain age range and NOT the creator. Latter was added because of eslint which required check for a variable that based on the api requirements MUST be present, but due to the other issue in the tests was not. Decoupling this if into two separate ones resolves the issue.
Comment on lines
-75
to
+89
| ...{ curators: { createdBy: curator._id } }, | ||
| ...{ curators: { createdBy: curatorMetadata.curator } }, |
There was a problem hiding this comment.
I updated it (and also one in the full case) from:
...{ curators: curatorMetadata.curator },
to:
...{ curators: { createdBy: curatorMetadata.curator } },
this triggered the hidden if coupling described above.
stanislaw-zakrzewski
approved these changes
Mar 25, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.