-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[98] add query for curator comments #154
[98] add query for curator comments #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @stanislaw-zakrzewski ,
-
I do see following issue with search for terms like
hello $
,hello /
,hello, this
. Can you please take a look if there are some restrictions on search terms
Hey @shaileshmahajanBCH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stanislaw-zakrzewski for all the work on this PR.
- Did notice that the search is not returning case records some times. I have 2 cases with the word "this" in it, But search result does not return that case
@shaileshmahajanBCH Initially I thought that it is an issue of parsing a query, but it is much more interesting 😮 The problem with searching for
According to documentation one of the features of text search with specified language (locale) is dropping "stop words" from search query: https://www.mongodb.com/docs/v5.3/core/index-text/#supported-languages-and-stop-words (full list of stop words for English language: https://github.com/igorbrigadir/stopwords/blob/master/en/mongodb.txt). And one of the stop words is We can resolve this problem by disabling all language specific features (stemming and stop words) by adding
And now we can search for But I'm not sure we should do that. Maybe we can just add a disclaimer that some of the "meaningless" words are not going to be taken care of by the search? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stanislaw-zakrzewski You are correct. Stop words are not indexed.
-
This link says the same - https://www.mongodb.com/docs/manual/core/indexes/index-types/index-text/specify-text-index-language/
-
May be quickly run it by Aimee or Product person to get their blessings, As they may need to know/document the stop words.
Solves: #98
Changes:
Screenshots:
Searching for a case with free-text (content in curators comment):
Updated DataGuideDialog content: