Skip to content

Commit

Permalink
[FIX 122] Revert passport version to 5.3.0 (#151)
Browse files Browse the repository at this point in the history
* Revert passport version to 5.3.0

* Fix logout issue
stanislaw-zakrzewski authored Sep 23, 2024
1 parent 810220e commit ef8820d
Showing 6 changed files with 68 additions and 97 deletions.
122 changes: 45 additions & 77 deletions verification/curator-service/api/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions verification/curator-service/api/package.json
Original file line number Diff line number Diff line change
@@ -38,10 +38,6 @@
"@types/lodash": "^4.17.4",
"@types/node": "^20.12.13",
"@types/nodemailer": "^6.4.15",
"@types/passport": "^1.0.16",
"@types/passport-google-oauth20": "^2.0.16",
"@types/passport-http-bearer": "^1.0.41",
"@types/passport-local": "^1.0.38",
"@types/pino": "^7.0.5",
"@types/supertest": "^6.0.2",
"@types/yamljs": "^0.2.34",
@@ -63,6 +59,10 @@
"typescript": "^5.4.5"
},
"dependencies": {
"@types/passport": "^1.0.4",
"@types/passport-google-oauth20": "^2.0.4",
"@types/passport-http-bearer": "^1.0.36",
"@types/passport-local": "^1.0.33",
"@types/swagger-ui-express": "^4.1.6",
"aws-sdk": "^2.1631.0",
"axios": "^1.7.2",
@@ -86,7 +86,7 @@
"mongodb": "^6.7.0",
"mongodb-memory-server": "^9.2.0",
"nodemailer": "^6.9.13",
"passport": "^0.7.0",
"passport": "^0.5.3",
"passport-google-oauth20": "^2.0.0",
"passport-http-bearer": "^1.0.1",
"passport-local": "^1.0.0",
8 changes: 3 additions & 5 deletions verification/curator-service/api/src/controllers/auth.ts
Original file line number Diff line number Diff line change
@@ -293,11 +293,9 @@ export class AuthController {
},
);

this.router.get('/logout', (req: Request, res: Response, next: NextFunction): void => {
req.logout(function(err) {
if (err) { return next(err); }
res.redirect('/');
});
this.router.get('/logout', function(req, res, next) {
req.logout();
res.status(200).json({ message: 'Logged out' });
});

// Starts the authentication flow with Google OAuth.
Loading

0 comments on commit ef8820d

Please sign in to comment.