Format dates to ISO8601 in ingestion #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Will strip times out when a midnight time has been provided, not ideal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 92.08% 92.24% +0.15%
==========================================
Files 39 39
Lines 1580 1611 +31
==========================================
+ Hits 1455 1486 +31
Misses 125 125 ☔ View full report in Codecov by Sentry. |
abhidg
reviewed
May 30, 2024
abhidg
approved these changes
May 30, 2024
…time fields to be transformed Accounts for extension fields with period/date in title which aren't datetime fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds arguments to
convert_data_to_flatfunction for the current date format and timezone.On ingestion dates/datetimes are converted to the ISO8601 standard.
FHIRflat natively has validation check that date format matches YYYY-MM-DD, but doesn't check for a timezone if a time is provided (https://github.com/nazrulworld/fhir.resources/blob/3f61a5e7963657ed354e2d02b938c62569583299/fhir/resources/fhirtypes.py#L518).
Chose not to put datetime options in google sheets mapping files to keep files streamlined.
Fixes #33, related to #32