-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code action to do string interpolation #4274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One small note inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please call it "Interpolate string" in both cases! String means what string.split
does, interpolate means to put something in the middle of text, which is what this does.
Oh ok! I'm fixing that (and also fixing a small bug I just noticed, might take a couple of minutes 😁) |
Done! Now it also works properly with pipelines, while before it would generate invalid code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
This PR fixes #4260
And this is what it looks like in practice: