Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code action to do string interpolation #4274

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

giacomocavalieri
Copy link
Member

This PR fixes #4260
And this is what it looks like in practice:

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One small note inline

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call it "Interpolate string" in both cases! String means what string.split does, interpolate means to put something in the middle of text, which is what this does.

@giacomocavalieri
Copy link
Member Author

Oh ok! I'm fixing that (and also fixing a small bug I just noticed, might take a couple of minutes 😁)

@giacomocavalieri
Copy link
Member Author

Done! Now it also works properly with pipelines, while before it would generate invalid code

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit 538192f into gleam-lang:main Feb 21, 2025
12 checks passed
@giacomocavalieri giacomocavalieri deleted the fix-4260 branch February 21, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Code action for string interpolation
2 participants