Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle nested FFI on publish #4256

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented Feb 18, 2025

Fixes #4238

Not sure if erlang_files should be modified as well, let me know if it'd be better to remove it from this PR.

@PgBiel PgBiel changed the title Export nested native Bundle nested FFI on publish Feb 18, 2025
@lpil
Copy link
Member

lpil commented Feb 18, 2025

Are you ready for a review? :)

@PgBiel
Copy link
Contributor Author

PgBiel commented Feb 18, 2025

Not yet, I'll be experimenting a bit further with include/ still, that's the only missing part. I'll let you know once it's ready!

@PgBiel PgBiel force-pushed the export-nested-native branch from e463685 to c93424e Compare February 22, 2025 03:40
@PgBiel PgBiel marked this pull request as ready for review February 22, 2025 03:42
@PgBiel
Copy link
Contributor Author

PgBiel commented Feb 22, 2025

Okay, I figured it out: the exported include/ directory is auto-generated on erlang codegen and is always flat (at least, the files produced by Gleam always appear at the top-level - not sure if erl can produce anything there, but I couldn't get it to at first), so 1. no need to export nested files and 2. no need for .gitignore checks (since the auto-generated dir is inside build/, so it would always be ignored...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested external FFI files are not bundled when publishing
2 participants