-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deps tree
functionality
#4172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Fantastic work! And the code looks really very good. Thank you.
I've left some very small notes inline
-p, --package <PACKAGE> Package to be used as the root of the tree | ||
-i, --invert <PACKAGE> Invert the tree direction and focus on the given package | ||
-h, --help Print help | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to show the format of the output here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a sample output, not sure if this is what we're looking for. Please let me know.
compiler-cli/src/main.rs
Outdated
help = "Package to be used as the root of the tree" | ||
)] | ||
package: Option<String>, | ||
/// (optional) Name of the package to get the inverted dependency tree for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the optional bit for these two comments please 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, removed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!!
Thank you, @lpil. Appreciate the review and the feedback. |
Oops I forgot to press the merge button |
Related to #3267.
Modified it to
gleam deps tree
based on the conversation in #3408 to make it more inline with howcargo tree
works.Currently supports
gleam deps tree
,gleam deps tree --package PACKAGE_NAME
, andgleam deps tree --invert PACKAGE_NAME
Sample output (project name: deps_list):
gleam deps tree
gleam deps tree --package pog
gleam deps tree --invert gleam_stdlib
Please let me know if I should change anything.