diff --git a/README.md b/README.md index c470034..a05d666 100644 --- a/README.md +++ b/README.md @@ -37,7 +37,7 @@ I believe these concerns are addressed here through screening of the file and it ### Performance ### -Unsurprisingly it's faster. Crude benchmarking (see the script [`perf_vs_imagick.php`](https://github.com/gitlost/gs-only-pdf-preview/blob/master/perf/perf_vs_imagick.php)) suggest it's around 40% faster. However the production of the preview is only a part of the overhead of uploading a PDF (and doesn't include producing the intermediate thumbnail sizes for instance) so any speed-up may not be that noticeable. +Unsurprisingly it's faster. Crude benchmarking (see the script [`perf_vs_imagick.php`](https://github.com/gitlost/gs-only-pdf-preview/blob/master/perf/perf_vs_imagick.php)) suggests it's around 40% faster. However the production of the preview is only a part of the overhead of uploading a PDF (and doesn't include producing the intermediate thumbnail sizes for instance) so any speed-up may not be that noticeable. On jpeg thumbnail size it appears to be comparable, maybe a bit larger on average. To mitigate this the default jpeg quality for the PDF preview has been lowered to 70 (from 82), which results in some extra "ringing" (speckles around letters) but the previews tested remain very readable. Note that this only affects the "full" PDF thumbnail - the intermediate-sized thumbnails as produced by `Imagick` or `GD` and any other non-PDF images remain at the standard jpeg quality of 82. Use the WP filter [`wp_editor_set_quality`](https://developer.wordpress.org/reference/hooks/wp_editor_set_quality/) to override this, for instance to restore the quality to 82 you could add to your theme's "functions.php": diff --git a/dist/gs-only-pdf-preview-1.0.0.zip b/dist/gs-only-pdf-preview-1.0.0.zip index f489ac3..eb5ab55 100644 Binary files a/dist/gs-only-pdf-preview-1.0.0.zip and b/dist/gs-only-pdf-preview-1.0.0.zip differ diff --git a/gs-only-pdf-preview.php b/gs-only-pdf-preview.php index 1d8c612..1e8090c 100644 --- a/gs-only-pdf-preview.php +++ b/gs-only-pdf-preview.php @@ -484,12 +484,12 @@ static function admin_enqueue_scripts( $hook_suffix ) { ); if ( $is_regen_pdf_preview ) { $params['please_wait_msg'] = '

' . __( 'Please wait...', 'gs-only-pdf-preview' ) - . '' . self::spinner( -2, true ) . '

'; + . '' . self::spinner( -2, true /*is_active*/ ) . '

'; $params['val']['poll_interval'] = self::$poll_interval; } elseif ( $is_upload ) { $params['no_items_selected_msg'] = '' . __( 'No items selected!', 'gs-only-pdf-preview' ) . ''; $params['action_not_available'] = __( 'Regenerate Preview ajax action not available!', 'gs-only-pdf-preview' ); - $params['spinner'] = self::spinner( 5, true ); + $params['spinner'] = self::spinner( 5, true /*is_active*/ ); $params['val']['min_time_limit'] = self::$min_time_limit; } $params = apply_filters( 'gopp_plugin_params', $params ); diff --git a/readme.txt b/readme.txt index 323a17f..84abc21 100644 --- a/readme.txt +++ b/readme.txt @@ -35,7 +35,7 @@ I believe these concerns are addressed here through screening of the file and it = Performance = -Unsurprisingly it's faster. Crude benchmarking (see the script [`perf_vs_imagick.php`](https://github.com/gitlost/gs-only-pdf-preview/blob/master/perf/perf_vs_imagick.php)) suggest it's around 40% faster. However the production of the preview is only a part of the overhead of uploading a PDF (and doesn't include producing the intermediate thumbnail sizes for instance) so any speed-up may not be that noticeable. +Unsurprisingly it's faster. Crude benchmarking (see the script [`perf_vs_imagick.php`](https://github.com/gitlost/gs-only-pdf-preview/blob/master/perf/perf_vs_imagick.php)) suggests it's around 40% faster. However the production of the preview is only a part of the overhead of uploading a PDF (and doesn't include producing the intermediate thumbnail sizes for instance) so any speed-up may not be that noticeable. On jpeg thumbnail size it appears to be comparable, maybe a bit larger on average. To mitigate this the default jpeg quality for the PDF preview has been lowered to 70 (from 82), which results in some extra "ringing" (speckles around letters) but the previews tested remain very readable. Note that this only affects the "full" PDF thumbnail - the intermediate-sized thumbnails as produced by `Imagick` or `GD` and any other non-PDF images remain at the standard jpeg quality of 82. Use the WP filter [`wp_editor_set_quality`](https://developer.wordpress.org/reference/hooks/wp_editor_set_quality/) to override this, for instance to restore the quality to 82 you could add to your theme's "functions.php":