Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable variant analysis submission integration tests #3800

Merged

Conversation

koesie10
Copy link
Member

This fixes the variant analysis submission integration tests by using the mock GitHub API server included in the extension to avoid issues with overriding the fetch function from outside of the extension code.

@koesie10 koesie10 marked this pull request as ready for review November 11, 2024 15:33
@koesie10 koesie10 requested review from a team as code owners November 11, 2024 15:33
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@koesie10 koesie10 merged commit 71cd892 into main Nov 12, 2024
27 checks passed
@koesie10 koesie10 deleted the koesie10/fix-variant-analysis-submission-integration-tests branch November 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants