Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting config setup #105

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 20, 2024

Pull Request

Proposed Changes

Standardize to match other github ospo github actions linting config setup. Trying to keep the linting configs the same between local and remote linting runs

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

Standardize to match other github ospo github actions linting
config setup.  Trying to keep the linting configs the same
between local and remote linting runs

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth requested a review from zkoppert as a code owner March 20, 2024 21:14
@zkoppert zkoppert added the infrastructure tests or other arch things label Mar 20, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks! 🚀

@zkoppert zkoppert merged commit 2880bf1 into github:main Mar 21, 2024
7 checks passed
@jmeridth jmeridth deleted the jm-linting-config-setup-changes branch March 21, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure tests or other arch things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants