Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup TypeScript tests and add two missing cases #352

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Cleanup TypeScript tests and add two missing cases #352

merged 1 commit into from
Nov 20, 2023

Conversation

hendrikvanantwerpen
Copy link
Collaborator

Adds two test for cases that were missing.

Also, cleanup the multifile tests to ensure fragment paths are normalized.

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner November 20, 2023 12:34
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Nov 20, 2023
robrix
robrix approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@hendrikvanantwerpen hendrikvanantwerpen merged commit a1d68a1 into main Nov 20, 2023
@hendrikvanantwerpen hendrikvanantwerpen deleted the ts-test-cleanup branch November 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrix robrix robrix approved these changes

Assignees

@hendrikvanantwerpen hendrikvanantwerpen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrikvanantwerpen @robrix