Vea problem 3 core implementation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6701422.
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
Co-Authored-By: Rob Rix <robrix@github.com>
hendrikvanantwerpen
previously approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Adds new stack graph rules and some rust code changes to make tests work.
Were these tests in Aleph, and were these new tests in https://github.com/github/aleph/pull/3165 that required this? I'm curious to understand what the problematic behavior was.
All old tests seem to pass unchanged?
That is surprising 🤔. I cannot immediately remember why this might be there, though.
Since none of the tests changed, and also none of the existing Aleph tests changed in https://github.com/github/aleph/pull/3165 either, this should be okay, I suppose :)
BekaValentine
dismissed
hendrikvanantwerpen’s stale review
Overlapping changes w/ other PRs; want confirmation that nothing is broken
robrix
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new stack graph rules and some rust code changes to make tests work. All old tests seem to pass unchanged?