Guard module names #347
Merged
Guard module names #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikvanantwerpen
force-pushed
the
js-only-export-main
branch
from
6339180 to
d8b4540
Compare
hendrikvanantwerpen
force-pushed
the
module-guard
branch
from
0c5fbc9 to
80b5d61
Compare
robrix
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Heh, I had a mental note to investigate this but you beat me to it 😄 Nice one!
@BekaValentine: heads up: I believe this will conflict with the stuff we were doing wrt the VEA living spec, tho I think it should be easy to reconcile (famous last words).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
« #340
Module names were not guarded, which led to a situation where variable names could resolve to a module name.
This PR changes that and ensures module names are always guarded by
GUARD:MODULE, preventing this bug.A new bug regression tests has been added to test for this case.