Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle scientific notation in label hex colors #708

Open
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from

Conversation

PendaGTP
Copy link

Fixes #707

Properly convert numeric hex colors that could be interpreted as scientific notation (e.g. 5319e7)

Before

labels:
  - name: "example"
    color: 5319e7  # 53190000000

After

labels:
  - name: "example"
    color: 5319e7  # 5319e7

Properly convert numeric hex colors that could be interpreted as scientific notation (e.g. 5319e7)
@anderssonjohan
Copy link
Contributor

@PendaGTP Please provide a test for your code. Such as:

const actualString = parseColorFromScientificNumber(5319e7);

expect(actualString).toEqual('5319e7');

Do you get these results with the provided code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label color parsing fails with scientific notation hex values
2 participants