ci: run tests on pull requests #375
Conversation
| "test": "npm-run-all --print-label --parallel lint:* --parallel test:*", | ||
| "lint:es": "eslint .", | ||
| "test": "npm-run-all --print-label --parallel test:*", | ||
| "citest": "npm-run-all --print-label --parallel \"test:* -- --reporters=github-actions\"", |
There was a problem hiding this comment.
Won't this also run test:me, test:unit:watch, test:integration:debug ? Maybe not a problem since npm test worked fine locally using the same argument to npm-run-all..
| @@ -7,8 +7,11 @@ | |||
| "scripts": { | |||
| "dev": "nodemon --inspect", | |||
| "start": "probot run ./index.js", | |||
| "test": "npm-run-all --print-label --parallel lint:* --parallel test:*", | |||
| "lint:es": "eslint .", | |||
| "test": "npm-run-all --print-label --parallel test:*", | |||
There was a problem hiding this comment.
Great work! With lint gone from npm test it would be awesome to add either a CONTRIBUTING.md file (or a simple "Development" heading in the repo readme) that states that it's expected to successfully run npm lint and npm test before posting a PR.
|
@martinm82 I just started looking at this and enabled to workflow to run. |
martinm82
force-pushed
the
ci/run-tests
branch
from
c0395f8 to
2415a0d
Compare
@decyjphr I would love to see the unit test passing. |
No description provided.