SafeSettings removes existing team permission for all the repos

[sajithvasu]

Github Safesettings app removes the existing teams permissions for all existing repositories within the org when the following mentioned settings are enabled. On the other hand, documentation does not specify removal of any existing permission when controlled through safesettings app. Is this the expected behavior?

settings.yml

repository:
teams:
  - name: <team_name>
    permission: <team_permission>

Our goal is to add specific permissions/teams to all the existing/new repos without impacting existing team permission for all the repos.

[martinm82]

I have discovered this issue as well and @decyjphr confirmed this here. It would be indeed good to update the existing settings instead of overriding them fully.

[decyjphr]

This fix has been released in 2.0.18

[martinm82]

@decyjphr should we close this issue? Also worth to add a reference to the pull request solving this problem.

[anderssonjohan]

Isn't this contradicting to #251? In my situation, I want to remove all manually added collaborators because it should only be a single source of truth when using this for policy-as-code. Related to fixes in #382