Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify github_domain? check + add test #172

Merged
merged 3 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github-pages-health-check/domain.rb
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def pages_dot_github_dot_com?

# Is this domain owned by GitHub?
def github_domain?
!!host.match(/(\A|\.)github\.com\.?\z/i)
host.downcase.eql?("github.com") || host.downcase.end_with?(".github.com")
end

# Is the host our Fastly CNAME?
Expand Down
8 changes: 8 additions & 0 deletions spec/github_pages_health_check/domain_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,14 @@
end
end

context "not github domains" do
let(:domain) { "somethinggithub.com" }

it "knows if the domain is not a github domain" do
expect(subject).to_not be_a_github_domain
end
end

context "fastly domain" do
let(:domain) { "github.map.fastly.net" }

Expand Down