Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify github_domain? check + add test #172

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Simplify github_domain? check + add test #172

merged 3 commits into from
Sep 10, 2024

Conversation

yoannchaudet
Copy link
Contributor

Iterate on #167.

  • Simplify check (don't assume regular expressions are easy to grok 😁)
  • Add test!

@yoannchaudet yoannchaudet requested a review from a team as a code owner September 10, 2024 16:10
@yoannchaudet yoannchaudet mentioned this pull request Sep 10, 2024
Merged
YiMysty
YiMysty previously approved these changes Sep 10, 2024
View reviewed changes
GretaP
GretaP previously approved these changes Sep 10, 2024
View reviewed changes
@YiMysty YiMysty dismissed stale reviews from GretaP and themself via 7f08daa September 10, 2024 18:51
@yoannchaudet yoannchaudet merged commit 4f2bb98 into master Sep 10, 2024
6 checks passed
@yoannchaudet yoannchaudet deleted the no-regex-🧠 branch September 10, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiMysty YiMysty YiMysty approved these changes

@parkr parkr parkr approved these changes

@GretaP GretaP GretaP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoannchaudet @parkr @YiMysty @GretaP