Pin redir_protocols #169
Merged
Pin redir_protocols #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Sep 10, 2024
|
That one will be annoying to test but I'll try to come up with something. I am getting the changes themselves vetted first ;) Switching to draft to clarify that state. |
yoannchaudet
commented
Sep 13, 2024
This reverts commit b2577bf.
yoannchaudet
commented
Sep 16, 2024
yoannchaudet
commented
Sep 16, 2024
yoannchaudet
commented
Sep 16, 2024
tsusdere
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue addresses https://github.com/github/pages-engineering/issues/5244.
Limit the redirection protocols we follow to HTTP/HTTPS only.
I did not find a way to test that with the mocking lib in the way. The
redirect_countmethod also does not exactly returned what we needed. When you cannot fake it, just do it...So to test the proper behaviors, we start a few real TCP servers in parallel to running the tests. We can confirm we get the behavior we need based on a log file written by the TCP servers. It is a bit clunky but does validate the behavior we are getting is the one we expect.