Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies to resolve security vulns #161

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Update Dependencies to resolve security vulns #161

merged 6 commits into from
Nov 15, 2023

Conversation

LadyKerr
Copy link
Contributor

@LadyKerr LadyKerr commented Nov 14, 2023

The most important changes include updating the header links, replacing anchor tags with Link components in the EventDetail and EventsList components, and updating the minimum required Node.js version in the build and test workflows.

Highlights:

  • As of Jest 28 "jest-environment-jsdom" is no longer shipped by default, and needs to be installed as a dev dependency
  • Starting with Next.js 13, renders as , so I updated all components to remove <a> tag as a child of <Link>
  • next export has been removed in favor of "output": "export", so I updated next.config
  • update node version in workflows

Main interface changes:

  • components/header/Header.jsx: Updated header links to improve accessibility and styling. [1] [2]
  • components/event-detail/EventDetail.jsx: Replaced anchor tags with Link components in EventDetail component.
  • components/events-list/EventsList.jsx: Improved accessibility and user experience by replacing an anchor tag with a Link component and adding a class to the "View more" link. [1] [2]

Configuration improvements:

  • .github/workflows/build-deploy.yml: Updated minimum Node.js version to 18.17.0 in build-deploy.yml file.
  • .github/workflows/test.yml: Updated minimum required Node.js version to 18.17.0 in test.yml file.

Dependency updates:

  • package.json: Updated dependencies to newer versions.
  • Main updates: react v18, react-dom v18, jest v29 and next v14

@LadyKerr LadyKerr added the dependencies Pull requests that update a dependency file label Nov 14, 2023
@LadyKerr LadyKerr self-assigned this Nov 14, 2023
Copy link
Contributor

@mvkaran mvkaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LadyKerr LadyKerr merged commit d7110d5 into main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants