-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How does this differ from jekyll-commonmark? #17
Comments
I also noticed github/pages-gem#699 which states that the |
For anyone else wondering, @pathawks provided an answer at jekyll/jekyll-commonmark#39 (comment), quoted here:
|
(Similar question posted at jekyll/jekyll-commonmark#39)
I notice that while the readme for
jekyll-commonmark
talks about usinglibcmark
, it actually appears to achieve this via thecommonmarker
gem.Looking at
commonmarker
, it talks about being a ruby wrapper forlibcmark-gfm
, which apparently includes all of the GFM extensions already:This would make me think that
jekyll-commonmark
by itself already supports GFM, and so i'm wondering whatjekyll-commonmark-ghpages
provides above/beyond that, particularly as this project also uses the samecommonmarker
gem.--
Adding
jekyll-commonmark
to my Gemfile resulted in the following in myGemfile.lock
:Resetting, then adding
jekyll-commonmark-ghpages
to myGemfile
resulted in the following in myGemfile.lock
:So
jekyll-commonmark-ghpages
gives us an additional version dependency onrouge
, but we already get that viajekyll
anyway:By the looks of this, by using
jekyll-commonmark
instead ofjekyll-commonmark-ghpages
I would actually be getting a more up to date version of commonmarker (and thus the underlying c implementation), that supports GFM. Which to me, at face value, is definitely not what I would have expected.I can see that there is a semi-related issue / PR (#13 , #15) talking about loosening the version lock on the commonmarker dependency, which would allow it to get the same newer version as
jekyll-commonmark
currently is able to. I also noticed #11 that talks about documenting the fact thatcommonmarker
is used under the hood, rather than a direct dependency onlibcmark-gfm
as this project's readme implies.The text was updated successfully, but these errors were encountered: