-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically build and release the CLI for the linux-arm64 build target #1235
base: main
Are you sure you want to change the base?
Conversation
Unit Test Results810 tests 810 ✅ 22s ⏱️ Results for commit a95b454. ♻️ This comment has been updated with latest results. |
RE #1230 (comment) I've essentially made a carbon copy of Tim's commit for |
@dylan-smith I was able to create a separate fork of this repository, merge this PR into it, and run a modified version of the CI workflow (which removed the E2E integration tests, as their success is required for the The modified CI workflow run produced working aarch64 builds for Linux in the I've invited you as an outside collaborator to that repository if you'd like to access/inspect the built artifacts on your end. |
I no longer work on the gei eng team (I just lurk in the repo), so one of the engineers from that team will have to shepherd this PR in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The only thing is -p:TrimMode=partial
MSBuild property needs to be added to all dotnet publish
commands prevent full trimming of assemblies. Starting with .NET 7, the default behavior changed from 'partial' to 'full', which will break the CLIs.
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
@ArinGhazarian Thanks for the heads up, and for the suggested edits. I’ve gone ahead and committed them. If there’s anything else you’d like me to address, I’ll gladly take care of it. Otherwise, we can 🚢 ✨ |
ThirdPartyNotices.txt
(if applicable)