Java: Add new quality query to detect empty methods #18947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+16
to
+20
| /** | ||
| * Represents a likely a test method, which is either a method that is already | ||
| * recognized as a `TestMethod` or something that is likely a JUnit test or | ||
| * something in the expected test path for Java tests. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
| ( | ||
| this.getName().matches("JUnit%") or | ||
| this.getName().matches("test%") or | ||
| this.getAnAnnotation().toString().matches("%Test") |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
Comment on lines
+55
to
+58
| /** | ||
| * Maven surefire patterns to consider which files are testcases: | ||
| * https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
| //permit comment lines explaining why this is empty | ||
| m.getNumberOfCommentLines() = 0 and | ||
| //permit a javadoc above as well as sufficient reason to leave empty | ||
| not exists(Javadoc jd | m.getDoc().getJavadoc() = jd) and |
Check warning
Code scanning / CodeQL
Expression can be replaced with a cast Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is migrated from the advance security team's quality queries.
The initial version was somewhat modified to report fewer alerts. The changes reduce the alert count in MRVA top 100 from 16800 to 3800.