New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Java: handle lock state check stored in variable for `java/unreleased-lock` #18900

Draft

jcogs33 wants to merge 2 commits into github:main from jcogs33:jcogs33/java/unreleased-lock-fp

+55 −10

Contributor

jcogs33 commented Feb 28, 2025

DRAFT

Jami Cogswell added 2 commits

February 28, 2025 00:43


          Java: initial experimentation

96f61ac


          Java: add 'variableLockCheck' predicate

github-actions bot added the Java label

github-advanced-security bot found potential problems

View reviewed changes

java/ql/src/Likely Bugs/Concurrency/UnreleasedLock.ql

Comment on lines +121 to +126

+              /**
+               * A variable access in `checkblock` that has `falsesucc` as the false successor.
+               *
+               * The variable access must have an assigned value that is a lock access on `t`, and
+               * the true successor of `checkblock` must contain an unlock access.
+               */

Check warning

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate without a result should start with 'Holds'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java