Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Various minor improvements in autobuilder implementation #15789

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Mar 4, 2024

This is a follow-up to #15361 to address review comments from there which do not affect the behaviour of the autobuilder.

@mbg mbg self-assigned this Mar 4, 2024
@github-actions github-actions bot added the Go label Mar 4, 2024
smowton
smowton previously approved these changes Mar 4, 2024
@mbg mbg force-pushed the mbg/go/autobuilder-review-comments branch from bc5af9f to acf2f76 Compare March 4, 2024 12:14
@mbg mbg marked this pull request as ready for review March 4, 2024 12:20
@mbg mbg requested a review from a team as a code owner March 4, 2024 12:20
owen-mc
owen-mc previously approved these changes Mar 4, 2024
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One punctuation-related nit.

go/extractor/project/project.go Outdated Show resolved Hide resolved
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
@mbg mbg dismissed stale reviews from owen-mc and smowton via 9b5bf51 March 4, 2024 12:25
@mbg mbg merged commit e5de4f2 into main Mar 4, 2024
12 checks passed
@mbg mbg deleted the mbg/go/autobuilder-review-comments branch March 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants