JS/TS/Python/Ruby: Renames diagnostic query files and tests #15465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames the files relating to the diagnostic query that produces information on the number of files extracted. The files have been renamed from "SuccessfullExtractedFiles.*" to "ExtractedFiles.*". All related tests and test files have been renamed too. The `@tags` and `@id` attributes of the queries have been left untouched, consistent with the `@tags` and `@id` for similar queries in other languages.
erik-krogh
approved these changes
Jan 30, 2024
aibaars
approved these changes
Jan 30, 2024
yoff
approved these changes
Jan 30, 2024
@erik-krogh That's right. I have added a backlink to the issue that outlines the recommended naming for attributes and file names. |
sidshank
deleted the
sidshank/rename-file-name-for-extracted-files-diagnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the files relating to the diagnostic query that produces information on the number of files extracted. The files have been renamed from
SuccessfullExtractedFiles.*toExtractedFiles.*. All related tests and test files have been renamed too.The
@tagsand@idattributes of the queries have been left untouched, consistent with the@tagsand@idfor similar queries in other languages.