Add additional test cases

github · Jan 29, 2024 · 460ffc8 · 460ffc8
1 parent 3abd670
commit 460ffc8
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/R.java b/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/R.java
@@ -14,6 +14,8 @@ public static final class id {
         public static final int test10 = 10;
         public static final int test11 = 11;
         public static final int test12 = 12;
+        public static final int test13 = 13;
+        public static final int test14 = 14;
     }
 
     public static final class string {

diff --git a/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/Test.java b/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/Test.java
@@ -60,5 +60,18 @@ void test(String password) {
         // GOOD: Visibility of parent set to invisible in XML
         EditText test12 = findViewById(R.id.test12);
         test12.setText(password);
+
+        // GOOD: Input type set to textPassword in XML
+        EditText test13 = findViewById(R.id.test13);
+        test13.setText(password);
+
+        test14 = findViewById(R.id.test14);
+    }
+
+    EditText test14;
+
+    void test2(String password) {
+        // GOOD: Input type set to textPassword in XML
+        test14.setText(password);
     }
 }
diff --git a/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/res/layout/Test.xml b/java/ql/test/query-tests/security/CWE-200/semmle/tests/SensitiveTextView/res/layout/Test.xml
@@ -50,4 +50,12 @@
             android:id="@+id/test12"/>
     </LinearLayout>
 
+    <EditText
+        android:id="@id/test13"
+        android:inputType="textPassword"/>
+
+    <EditText
+        android:id="@+id/test14"
+        android:inputType="textPassword"/>
+
 </LinearLayout>