Go: Emit relative path import diagnostic if prompted by go mod tidy

The corresponding integration test now successfully extracts the project
github · Jan 24, 2024 · 45c349a · 45c349a
1 parent cd35b6f
commit 45c349a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/go/extractor/cli/go-autobuilder/go-autobuilder.go b/go/extractor/cli/go-autobuilder/go-autobuilder.go
@@ -463,8 +463,15 @@ func initGoModForLegacyProject(buildInfo project.BuildInfo) {
 	modTidy := exec.Command("go", "mod", "tidy")
 	modTidy.Dir = buildInfo.BaseDir
 
-	if !util.RunCmd(modTidy) {
+	out, err := modTidy.CombinedOutput()
+	log.Println(out)
+
+	if err != nil {
 		log.Printf("Failed to determine module requirements for this project.")
+
+		if strings.Contains(string(out), "is relative, but relative import paths are not supported in module mode") {
+			diagnostics.EmitRelativeImportPaths()
+		}
 	}
 }
 

diff --git a/go/ql/integration-tests/all-platforms/go/diagnostics/unsupported-relative-path/test.py b/go/ql/integration-tests/all-platforms/go/diagnostics/unsupported-relative-path/test.py
@@ -10,7 +10,7 @@
 goPath = os.path.join(os.path.abspath(os.getcwd()), ".go")
 os.environ['GOPATH'] = goPath
 os.environ['GITHUB_REPOSITORY'] = "a/b"
-run_codeql_database_create([], lang="go", source="work", db=None, runFunction=runUnsuccessfully)
+run_codeql_database_create([], lang="go", source="work", db=None)
 
 check_diagnostics()