Merge pull request #15432 from tamasvajk/fix/extraction-information

C#: Filter results of division by 0 from `cs/telemetry/extraction-information`
github · Jan 25, 2024 · 2333b8d · 2333b8d
2 parents 01b8950 + 055ead2
commit 2333b8d
Showing 1 changed file with 33 additions and 25 deletions.
diff --git a/csharp/ql/src/Telemetry/ExtractorInformation.ql b/csharp/ql/src/Telemetry/ExtractorInformation.ql
@@ -167,29 +167,37 @@ module ExprStatsReport = ReportStats<ExprStats>;
 
 from string key, float value
 where
-  fileCount(key, value) or
-  fileCountByExtension(key, value) or
-  totalNumberOfLines(key, value) or
-  numberOfLinesOfCode(key, value) or
-  totalNumberOfLinesByExtension(key, value) or
-  numberOfLinesOfCodeByExtension(key, value) or
-  extractorDiagnostics(key, value) or
-  numberOfAmbiguityCompilerErrors(key, value) or
-  numberOfDistinctAmbiguityCompilerErrorMessages(key, value) or
-  extractionIsStandalone(key, value) or
-  CallTargetStatsReport::numberOfOk(key, value) or
-  CallTargetStatsReport::numberOfNotOk(key, value) or
-  CallTargetStatsReport::percentageOfOk(key, value) or
-  ExprTypeStatsReport::numberOfOk(key, value) or
-  ExprTypeStatsReport::numberOfNotOk(key, value) or
-  ExprTypeStatsReport::percentageOfOk(key, value) or
-  TypeMentionTypeStatsReport::numberOfOk(key, value) or
-  TypeMentionTypeStatsReport::numberOfNotOk(key, value) or
-  TypeMentionTypeStatsReport::percentageOfOk(key, value) or
-  AccessTargetStatsReport::numberOfOk(key, value) or
-  AccessTargetStatsReport::numberOfNotOk(key, value) or
-  AccessTargetStatsReport::percentageOfOk(key, value) or
-  ExprStatsReport::numberOfOk(key, value) or
-  ExprStatsReport::numberOfNotOk(key, value) or
-  ExprStatsReport::percentageOfOk(key, value)
+  (
+    fileCount(key, value) or
+    fileCountByExtension(key, value) or
+    totalNumberOfLines(key, value) or
+    numberOfLinesOfCode(key, value) or
+    totalNumberOfLinesByExtension(key, value) or
+    numberOfLinesOfCodeByExtension(key, value) or
+    extractorDiagnostics(key, value) or
+    numberOfAmbiguityCompilerErrors(key, value) or
+    numberOfDistinctAmbiguityCompilerErrorMessages(key, value) or
+    extractionIsStandalone(key, value) or
+    CallTargetStatsReport::numberOfOk(key, value) or
+    CallTargetStatsReport::numberOfNotOk(key, value) or
+    CallTargetStatsReport::percentageOfOk(key, value) or
+    ExprTypeStatsReport::numberOfOk(key, value) or
+    ExprTypeStatsReport::numberOfNotOk(key, value) or
+    ExprTypeStatsReport::percentageOfOk(key, value) or
+    TypeMentionTypeStatsReport::numberOfOk(key, value) or
+    TypeMentionTypeStatsReport::numberOfNotOk(key, value) or
+    TypeMentionTypeStatsReport::percentageOfOk(key, value) or
+    AccessTargetStatsReport::numberOfOk(key, value) or
+    AccessTargetStatsReport::numberOfNotOk(key, value) or
+    AccessTargetStatsReport::percentageOfOk(key, value) or
+    ExprStatsReport::numberOfOk(key, value) or
+    ExprStatsReport::numberOfNotOk(key, value) or
+    ExprStatsReport::percentageOfOk(key, value)
+  ) and
+  /* Infinity */
+  value != 1.0 / 0.0 and
+  /* -Infinity */
+  value != -1.0 / 0.0 and
+  /* NaN */
+  value != 0.0 / 0.0
 select key, value