Update metrics fetcher to use a Typescript-based pipeline #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're exploring using TypeScript and octokit for our backend instead of Go. This adds a basic typescript structure and command to fetch data. The basic idea is that we can now use pipeline functions to append data to our result. This should make it easier to compose data. If this continues to look promising, we can add a test to compare to the results of the Go backend to ensure we're getting the same data. Co-authored-by: Andrew Henry <ajhenry@github.com>
This uses fs-extra to generate a JSON file. In the future we'll be able to move the file location to generate into the UI app directory. Co-authored-by: Andrew Henry <ajhenry@github.com>
ipc103
reviewed
Jan 31, 2024
| repo: repoName, | ||
| state: state, | ||
| // Need to limit this query somehow, otherwise it will take forever/timeout | ||
| since: config.since, |
There was a problem hiding this comment.
This is actually pretty nice because I think this means we'll be able to reuse this for some very basic time-based snapshots i.e. age 6 months ago, 3 months ago, today, something like that?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| }; | ||
|
|
||
| const calculateIssueResponseTime = async ( |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
There was a problem hiding this comment.
Going to merge this for now anyway, we will redo this later.
… data shape changes
The name is easier to read, so we'll use this for the UI/data instead of the spdxId. Co-authored-by: Andrew Henry <ajhenry@github.com>
ipc103
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old go-based data fetching backend with a typescript-based pipeline-inspired backend. The objective of this work is to make it easier to read and write fetching data from the github api and performing transformations on it.
This PR accomplishes the following:
data.jsonfile generated by the go backendThings that need to be fleshed out
Things we need to address
collaboratorsCount is missingprojectsCount is missingissuesCount is missing (total of all issues not including PR's)openIssues count includes PR'sopenPullRequestCount is incorrectmergedPullRequestsCount is missingcc: @ipc103
closes https://github.com/github/ospo/issues/1993