Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework directory structure #114

Merged
merged 24 commits into from
Mar 26, 2024
Merged

Rework directory structure #114

merged 24 commits into from
Mar 26, 2024

Conversation

ajhenry
Copy link
Collaborator

@ajhenry ajhenry commented Mar 20, 2024

This does a lot so hold onto your 🎩s

  • Renamed backend and frontend folders to backend and app respectively
  • Hoisted env files to root
  • Renamed backend start to dev
  • Deleted old go backend
  • Reworked deploy workflow
  • Setup npm workspaces

@Lehcar Lehcar mentioned this pull request Mar 25, 2024
Copy link
Collaborator

@ipc103 ipc103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are mostly related to:

  • renaming files
  • removing Tremor
  • Running prettier/eslint

Change LGTM! I'll test Codespaces once this merges just to make sure we're still in good shape there 👍

@@ -1,17 +0,0 @@
{
"typescript.enablePromptUseWorkspaceTsdk": true,
"typescript.format.enable": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember, was this replaced by prettier config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

@@ -0,0 +1,232 @@
/* eslint-disable import/no-extraneous-dependencies */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file from a template? If so, might be helpful to link to it for reference?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was here when I joined the project but has lots of github related rules

"settings": {}
},
"extensions": [
"github.copilot",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to test this after merging, as I'm not sure how to create a Codespace using the file from this branch. I think it should work though.

FWIW Co-pilot was not installed in my new Codespace by default, but golang.go was, so I'm not sure what happened there 🤷

@ajhenry ajhenry merged commit 052ef50 into main Mar 26, 2024
4 checks passed
@ajhenry ajhenry deleted the ajhenry/cleanup branch March 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants