Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assembly trimming and single-file publish on all platforms #1419

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Enable assembly trimming and single-file publish on all platforms #1419

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a0babfc
dotnet: update from .NET 7 to .NET 8
mjcheetham Sep 11, 2023
09f6421
dotnet: drop .NET 4.7.2 for .NET 8
mjcheetham Sep 11, 2023
26735d1
dotnet: drop .NET Framework-specific code
mjcheetham Sep 11, 2023
3c1406e
build: annotate platform-specific code
mjcheetham Sep 18, 2023
47072be
ci: install .NET 8 SDK in CI and builds
mjcheetham Sep 20, 2023
d25c50a
avalonia: enable compiled bindings for all UI
mjcheetham Sep 13, 2023
3c25ca1
json: use source generation for JSON serialization
mjcheetham Sep 13, 2023
da2fcd7
build: enable trimming and single file publish
mjcheetham Sep 13, 2023
effdac4
build: add MSAL single file publish workaround
mjcheetham Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: enable trimming and single file publish
  • Loading branch information
@mjcheetham
mjcheetham committed Oct 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit da2fcd772f59b62e6715537ca601916514992460
1 change: 0 additions & 1 deletion src/linux/Packaging.Linux/layout.sh
View file
Original file line number Diff line number Diff line change
@@ -74,7 +74,6 @@ $DOTNET_ROOT/dotnet publish "$GCM_SRC" \
--framework="$FRAMEWORK" \
--runtime="$RUNTIME" \
--self-contained \
-p:PublishSingleFile=true \
--output="$(make_absolute "$PAYLOAD")" || exit 1

# Collect symbols
1 change: 0 additions & 1 deletion src/osx/Installer.Mac/layout.sh
View file
Original file line number Diff line number Diff line change
@@ -21,7 +21,6 @@ SRC="$ROOT/src"
OUT="$ROOT/out"
INSTALLER_SRC="$SRC/osx/Installer.Mac"
GCM_SRC="$SRC/shared/Git-Credential-Manager"
GCM_UI_SRC="$SRC/shared/Git-Credential-Manager.UI.Avalonia"

# Build parameters
FRAMEWORK=net8.0
3 changes: 3 additions & 0 deletions src/shared/Git-Credential-Manager/Git-Credential-Manager.csproj
View file
Original file line number Diff line number Diff line change
@@ -10,6 +10,9 @@
<IsTestProject>false</IsTestProject>
<LangVersion>latest</LangVersion>
<TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
<PublishSingleFile>true</PublishSingleFile>
<PublishTrimmed>true</PublishTrimmed>
<InvariantGlobalization>true</InvariantGlobalization>
</PropertyGroup>

<ItemGroup>