fixtures: nettoyage de dump_data.sh
#5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
EwenKorr
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Tant qu'on est dans du nettoyage, on pourrait enlever du .PHONY:
populate_db_with_cities(ça aurait pu être fait dans le commit mentionné, f695969#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R63)populate_db_minimal(commit 835203d)
|
Bien vu, c'est fait 👍 |
xavfernandez
force-pushed
the
xfernandez/cleanup_dump_data
branch
from
cfdd064 to
64d94f6
Compare
EwenKorr
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Ces données sont maintenant dans des fichiers SQL.
Cette modif aurait du être dans le commit f695969.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran