TECH - ajout de la tâche de déploiement automatisé de l'env de pentest #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app: |
JeromeBu
reviewed
Jan 21, 2025
| @@ -242,7 +243,7 @@ export class AppConfig { | |||
| public get envType() { | |||
| return this.#throwIfNotInArray({ | |||
| variableName: "ENV_TYPE", | |||
| authorizedValues: ["dev", "staging", "production", "local"], | |||
| authorizedValues: [...environments], | |||
There was a problem hiding this comment.
Suggested change
| authorizedValues: [...environments], | |
| authorizedValues: environments, |
| @@ -10,7 +14,7 @@ const getBoolean = makeGetBooleanVariable(windowEnv); | |||
| export const ENV = { | |||
| envType: throwIfNotInArray({ | |||
| variableName: "VITE_ENV_TYPE", | |||
| authorizedValues: ["dev", "staging", "production", "local"], | |||
| authorizedValues: [...environments], | |||
There was a problem hiding this comment.
idem
authorizedValues: environments,
```
JeromeBu
approved these changes
Jan 21, 2025
JeromeBu
force-pushed
the
tech/pentest
branch
from
e4e3a47 to
53f549a
Compare
JeromeBu
force-pushed
the
tech/pentest
branch
from
53f549a to
edfc818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.