Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptif des changements apportés :
v1
etv0
soussrc/data_inclusion/api/
.analytics
,inclusion_data
etinclusion_schema
.v0
dans les tests.src/data_inclusion/api/v0/inclusion_schema/legacy
.src/data_inclusion/api/app.py
).data_inclusion_schema
(src/data_inclusion/api/v1/inclusion_data/routes.py
).Questions :
Quels éléments de
v0
peut-on factoriser avecv1
?src/data_inclusion/api/v0/analytics/models.py
→ Très bon candidat, on souhaite garder une structure commune entre les versions.src/data_inclusion/api/v0/inclusion_data/commands.py
→ Plus discutable.D'autres fichiers avec des dépendances sont-ils a dupliqués dans
v0
et `v1 ?src/data_inclusion/api/utils/soliguide.py
?src/data_inclusion/api/decoupage_administratif/commands.py
?