[charts/onechart] Specifying ports in values doesn't work as expected

[davidfrickert]

Specifying ports in values doesn't work as expected.

E.g.:

ports:
  - name: 445
    svcPort: 445

The template tries to fill the name in both the actual name and in targetPort, which doesn't work, as port needs to be a number and name needs to be a string:

Error: INSTALLATION FAILED: Service in version "v1" cannot be handled as a Service: json: cannot unmarshal number into Go struct field ServicePort.spec.ports.name of type string

onechart/charts/onechart/templates/service.yaml

Lines 65 to 73 in 906958c

	{{- else }}
	{{- range .Values.ports }}
	- name: {{ .name }}
	port: {{ if .svcPort }}{{ .svcPort }}{{ else }}{{ .containerPort }}{{ end }}
	{{- if .nodePort }}
	nodePort: {{ .nodePort }}
	{{- end }}
	targetPort: {{ .name }}
	protocol: TCP

Instead, maybe support passing targetPort?

ports:
  - name: tcp-445
    svcPort: 445
    targetPort: 445

Offtopic

Name could also be optional:

ports:
  - svcPort: 445
    targetPort: 445

The template could then fill the port name with a concatenation of tcp and the port.

[laszlocph]

Hello @davidfrickert

.Values.ports is an undocumented feature, and honestly we forgot why it is in Onechart in the first place.

But the following values file produces valid yaml, and seemingly we support multiple ports.

ports:
  - name: blabla
    containerPort: 445
  - name: blabla2
    containerPort: 446

containerPort: 446

You are right about the fact that the template tries to fill the name in both the actual name and in targetPort. TargetPort can be a string and OneChart produces internally consistent yaml.

So the question is, is there something we don't support? Why did you want to provide a port number as name and not a string?

[davidfrickert]

Ah I see, I wasn't aware targetPort could be a string.
I guess I was just looking for a way to do something similar to docker compose, defining external and internal port, without having to use a name for the port.