Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix padding and alignment elements on quiz session header #197

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

rbacordio
Copy link
Contributor

  • Fix horizontal padding on question counter
  • Center question set name
  • Add question set counter on Header

Copy link
Contributor

@jaymar921 jaymar921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

<p className="text-white text-sm mb-2">
{metadata?.currentSetName}
<p className="text-white text-sm mb-2 text-center">
{`(${metadata?.currentSetIndex}/${metadata?.totalNumberOfSets}) ${metadata?.currentSetName}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm

@@ -22,6 +22,8 @@ export default function Header() {
{ volume: isMute ? 0 : volume / 100 }
);

console.log(metadata);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this in the future

@rbacordio rbacordio added the fix When you're fixing a bug or resolving an issue in the code, use this category. label Mar 15, 2024
removed the console.log(metadata)
Copy link
Contributor

@kinloveko kinloveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMAY!

@kinloveko kinloveko merged commit f5beb2d into develop Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix When you're fixing a bug or resolving an issue in the code, use this category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants